I haven't done much with the peer code, but there must be a reason someone commented those lines out. Is this well tested with multiple games? If so I'm fine with merging.

This was commented out with 1c7152d
which was part of #7264

Hate the fact that soo much things in this code are commented out without actual comment on reason... Just a guess, but maybe some games are disconnecting too early hence it was disabled to make it playable as improved compatibility was primary reason behind people wanting that pr to be merged.

Feels risky to merge right before release.

Unfortunately I have only tested with Monster Hunter games, they work at least. During a multiplayer session it should be working normally as before because they are only called when you disconnect, sceNetAdhocctlDisconnect(). So it shouldn't remove any peer prior to that. And if you disconnect you would need to reconnect anyway so the peers would be added again.

I checked if deleteFriendByIP() could cause an exception if friends == NULL but luckily the for-loop only runs when it's != NULL.

Code wise it doesn't seem to be a problem but who knows what the games can do.

Game that not affected by this pull request all game below working normally

• Monster Hunter Freedom Unite
• Monster Hunter Portable 3RD
• God Eater Burst
• God Eater 2
• Yu-Gi-Oh! 5D's Tag Force 6
• Dissidia 012 Duodecim Final Fantasy
• More test coming

@adenovan How do you feel about this pull request? I don't do much network gaming but if you've tested it with a lot of games, I'm fine with merging this. Code-wise, it seems correct.

@hrydgard i feel this PR is safe to merge because almost all of my games work without problem but it still a few list of game if compared with adhoc compability list on forums. i will ask facebook openvpn comunity to do more test on game that i didn't have. so i can list what game call this cleared peer list function and break the networking that works before. this pull request is really needed for Monster Hunter game because #7331 is really an annoying bug specially for playing online with random people. the list on my previous comment will be updated for the info what game work and what game broken by this PR.

@adenovan Just poking to check if there has been more tests recently.

What kind of games that many people play which are not on the list above are left to be tested? I assume Tekken 6 should be checked before concluding. It seems good so far, no broken games yet.

Let's go for it and see if there are complaints instead, at this point.